Skip to content

fix: remove redundant font family from stylesheet link - #8942

Merged
Soulter merged 1 commit into
masterfrom
perf/webui-unnecessary-font
Jun 21, 2026
Merged

Soulter merged 1 commit into
masterfrom
perf/webui-unnecessary-font

Conversation

@Soulter

@Soulter Soulter commented Jun 21, 2026 •

Copy link
Copy Markdown
Member

Modifications / 改动点

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txt 和 pyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Stop loading the redundant Noto Sans SC font from Google Fonts in the dashboard.

@vercel

vercel Bot commented Jun 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astr-bot Ready Ready Preview, Comment Jun 21, 2026 3:36pm

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:webui The bug / feature is about webui(dashboard) of astrbot. labels Jun 21, 2026
@Soulter
Soulter merged commit 16beb9a into master Jun 21, 2026
21 of 22 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Given the bilingual (including Chinese) content in this project, please double-check that removing Noto Sans SC doesn’t break rendering for any pages that relied on that CJK font and that appropriate fallbacks remain in the CSS font stack.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Given the bilingual (including Chinese) content in this project, please double-check that removing `Noto Sans SC` doesn’t break rendering for any pages that relied on that CJK font and that appropriate fallbacks remain in the CSS font stack.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'Noto Sans SC' font family from the Google Fonts stylesheet link in dashboard/index.html. The reviewer noted that removing this font family could lead to inconsistent rendering and typography issues for Chinese users, as the dashboard contains Chinese text and 'Noto Sans' does not include Simplified Chinese characters. It is recommended to retain 'Noto Sans SC' to ensure proper localization support.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dashboard/index.html
<link
rel="stylesheet"
href="https://fonts.googleapis.com/css2?family=Outfit&family=Noto+Sans:wght@100..900&family=Noto+Sans+SC:wght@100..900&display=swap"
href="https://fonts.googleapis.com/css2?family=Outfit&family=Noto+Sans:wght@100..900&display=swap"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing Noto Sans SC might cause typography issues for Chinese users. On Google Fonts, Noto Sans does not include Simplified Chinese characters due to file size constraints; Noto Sans SC is specifically required for Chinese characters. Since the dashboard has Chinese text (e.g., <title>AstrBot - 仪表盘</title>), removing this font family will cause Chinese text to fall back to system fonts, leading to inconsistent rendering across different platforms. Please keep Noto Sans SC if Chinese language support is intended.

Suggested change
href="https://fonts.googleapis.com/css2?family=Outfit&family=Noto+Sans:wght@100..900&display=swap"
href="https://fonts.googleapis.com/css2?family=Outfit&family=Noto+Sans:wght@100..900&family=Noto+Sans+SC:wght@100..900&display=swap"

@Soulter
Soulter deleted the perf/webui-unnecessary-font branch June 21, 2026 15:41
KBVsent pushed a commit to KBVsent/AstrBot that referenced this pull request Jul 13, 2026
KBVsent pushed a commit to KBVsent/AstrBot that referenced this pull request Jul 13, 2026

This branch was successfully deployed

1 active deployment
Preview — 51fb76fb Deployed Jun 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webui The bug / feature is about webui(dashboard) of astrbot. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant