Repository navigation
fix: remove redundant font family from stylesheet link - #8942
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Given the bilingual (including Chinese) content in this project, please double-check that removing
Noto Sans SCdoesn’t break rendering for any pages that relied on that CJK font and that appropriate fallbacks remain in the CSS font stack.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Given the bilingual (including Chinese) content in this project, please double-check that removing `Noto Sans SC` doesn’t break rendering for any pages that relied on that CJK font and that appropriate fallbacks remain in the CSS font stack.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request removes the 'Noto Sans SC' font family from the Google Fonts stylesheet link in dashboard/index.html. The reviewer noted that removing this font family could lead to inconsistent rendering and typography issues for Chinese users, as the dashboard contains Chinese text and 'Noto Sans' does not include Simplified Chinese characters. It is recommended to retain 'Noto Sans SC' to ensure proper localization support.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <link | ||
| rel="stylesheet" | ||
| href="https://fonts.googleapis.com/css2?family=Outfit&family=Noto+Sans:wght@100..900&family=Noto+Sans+SC:wght@100..900&display=swap" | ||
| href="https://fonts.googleapis.com/css2?family=Outfit&family=Noto+Sans:wght@100..900&display=swap" |
There was a problem hiding this comment.
Removing Noto Sans SC might cause typography issues for Chinese users. On Google Fonts, Noto Sans does not include Simplified Chinese characters due to file size constraints; Noto Sans SC is specifically required for Chinese characters. Since the dashboard has Chinese text (e.g., <title>AstrBot - 仪表盘</title>), removing this font family will cause Chinese text to fall back to system fonts, leading to inconsistent rendering across different platforms. Please keep Noto Sans SC if Chinese language support is intended.
| href="https://fonts.googleapis.com/css2?family=Outfit&family=Noto+Sans:wght@100..900&display=swap" | |
| href="https://fonts.googleapis.com/css2?family=Outfit&family=Noto+Sans:wght@100..900&family=Noto+Sans+SC:wght@100..900&display=swap" |
Modifications / 改动点
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Bug Fixes: