Premium Analytics: add metrics attribute to Traffic and Subscribers charts#50390
Open
retrofox wants to merge 1 commit into
Open
Premium Analytics: add metrics attribute to Traffic and Subscribers charts#50390retrofox wants to merge 1 commit into
retrofox wants to merge 1 commit into
Conversation
traffic and subscribers charts filter their tabs via ArrayCheckboxField
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WOOA7S-1685
Proposed changes
metricsarray attribute (Edit: ArrayCheckboxField,relevance: 'high') on the two MetricTabsChart widgets, alongside their existinggranularityattribute.example.attributesdoubles as the defaults for new instances (all metrics enabled).views,visitors,likes,comments) move fromuse-traffic-chart.tsintowidget.tsas the single source for the settings checkboxes and the chart tabs. The hook filters the tabs by the selected ids and skips a pair's request entirely (enabled: false) while neither of its fields is selected.subscribers,paid) move fromrender.tsxintowidget.ts;buildMetricsfilters by the selected ids, and the Paid subscribers tab keeps rendering only when the site has paid subscribers.metricscheck control plus the real attribute schema in the dashboard story's settings drawer.descriptionfrom bothwidget.tsfiles:widget.jsonis the source of truth for static widget metadata.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
jp build packages/premium-analytics --depsviews,visitorsrequest is not sent; uncheck everything and confirm the "No metric selected" message.