Skip to content

Add TypeScript Spector coverage for multipart and optional response bodies - #5411

Merged
Jialin Huang (JialinHuang803) merged 2 commits into
mainfrom
copilot/verify-implement-spector-tests
Sep 7, 2026
Merged

Add TypeScript Spector coverage for multipart and optional response bodies#5411
Jialin Huang (JialinHuang803) merged 2 commits into
mainfrom
copilot/verify-implement-spector-tests

Conversation

Copilot AI commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Adds TypeScript integration coverage for 19 supported Spector scenarios. Unsupported SSE protocol handling and XML continuation remain excluded with concise blockers.

Spector test results

Streaming_Sse_Protocol_Data

  • ❌ Failed: withEnvelope — generated clients expose raw streams without typed SSE event parsing.
  • ❌ Failed: withoutEnvelope — generated clients expose raw streams without typed SSE event parsing.

Streaming_Sse_Protocol

  • ❌ Failed: id — SSE ID metadata is not parsed.
  • ❌ Failed: invalidId — SSE ID validation is not implemented.
  • ❌ Failed: invalidRetry — SSE retry metadata is not parsed.
  • ❌ Failed: reconnect — reconnection and Last-Event-ID handling are not implemented.
  • ❌ Failed: retry — SSE retry metadata is not parsed.

Response_BodyOrNoContentresponse-body-or-no-content.test.ts

  • ✅ Added: getBody
  • ✅ Added: getNoContent

Payload_Pageable_XmlPaginationpayload-pageable.test.ts

  • ❌ Failed: listWithContinuation — iteration stops after the first XML page without sending the continuation marker.

Payload_MultiPart_FormDatapayload-multipart.test.ts

  • ✅ Added: anonymousModel
  • ✅ Added: basic
  • ✅ Added: binaryArrayParts
  • ✅ Added: checkFileNameAndContentType
  • ✅ Added: fileArrayAndBasic
  • ✅ Added: jsonPart
  • ✅ Added: multiBinaryParts
  • ✅ Added: optionalParts
  • ✅ Added: withWireName

Payload_MultiPart_FormData_HttpParts_ContentTypepayload-multipart.test.ts

  • ✅ Added: imageJpegContentType
  • ✅ Added: optionalContentType
  • ✅ Added: requiredContentType

Payload_MultiPart_FormData_HttpPartspayload-multipart.test.ts

  • ✅ Added: jsonArrayAndFileArray

Payload_MultiPart_FormData_HttpParts_NonStringpayload-multipart.test.ts

  • ✅ Added: float

Payload_MultiPart_FormData_Filepayload-multipart.test.ts

  • ✅ Added: uploadFileArray
  • ✅ Added: uploadFileRequiredFilename
  • ✅ Added: uploadFileSpecificContentType

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: JialinHuang803 <139532647+JialinHuang803@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:typescript Issues for @azure-tools/typespec-ts emitter label Sep 7, 2026
Copilot AI changed the title [WIP] Verify and implement Spector integration tests for scenario groups Add TypeScript Spector coverage for multipart and optional response bodies Sep 7, 2026
@JialinHuang803
Jialin Huang (JialinHuang803) marked this pull request as ready for review September 7, 2026 05:45
@pkg-pr-new

pkg-pr-new Bot commented Sep 7, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-ts@5411

commit: 686b3c4

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

You can try these changes here

🛝 Playground 🌐 Website

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qiaozha Qiaoqiao Zhang (qiaozha) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check whether those MFD related issues are resolved and could be closed?

@JialinHuang803

Copy link
Copy Markdown
Member

please check whether those MFD related issues are resolved and could be closed?

The items listed in the #4757 are not covered by these spector tests. Let's keep the issue open.

@JialinHuang803
Jialin Huang (JialinHuang803) added this pull request to the merge queue Sep 7, 2026
Merged via the queue into main with commit 9fe5c80 Sep 7, 2026
36 checks passed
@JialinHuang803
Jialin Huang (JialinHuang803) deleted the copilot/verify-implement-spector-tests branch September 7, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:typescript Issues for @azure-tools/typespec-ts emitter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Copilot] Verify and implement Spector tests for 9 scenario groups

3 participants