Skip to content

build: Bump dependencies - #67

Merged
LarsV123 merged 3 commits into
mainfrom
2026-11-06-bump-dependencies
Nov 6, 2026
Merged

LarsV123 merged 3 commits into
mainfrom
2026-11-06-bump-dependencies

Conversation

@LarsV123

@LarsV123 LarsV123 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Routine dependency bump.

Changes:

  • build: Upgrade Gradle to 9.8.2
  • build: Bump nva-gradle-plugins to 1.0.14
  • build: Bump nva-commons to 2.11.2

Worth a look:

  • Upgrades nva-gradle-plugins to use the new shared PMD configuration, instead of a full local override.
    This turns on the bestpractices, multithreading and performance categories for main code, while test sources stay out of PMD as before.
    GuardLogStatement is excluded as in the other repositories, and UnnecessaryLocalBeforeReturn (deprecated in PMD 7) is replaced by its successor VariableCanBeInlined.

@codacy-production

codacy-production Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (74adfb4) 195 195 100.00%
Head commit (e4eec4b) 195 (+0) 195 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#67) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@LarsV123
LarsV123 added this pull request to stack #69 November 6, 2026 10:11
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Test Results

16 tests  ±0   16 ✅ ±0   15s ⏱️ +2s
 2 suites ±0    0 💤 ±0 
 2 files   ±0    0 ❌ ±0 

Results for commit e4eec4b. ± Comparison against base commit 74adfb4.

♻️ This comment has been updated with latest results.

Uses the shared PMD ruleset from nva-gradle-plugins with repository exclusions, instead of a full local override. Test sources stay out of PMD as before. GuardLogStatement is excluded as in the other repositories, and UnnecessaryLocalBeforeReturn becomes VariableCanBeInlined, its replacement in PMD 7.
@LarsV123
LarsV123 force-pushed the 2026-11-06-bump-dependencies branch from c291dcf to e4eec4b Compare November 6, 2026 11:40
}
pmd {
rulesetFile = rootProject.file('config/pmd/ruleset.xml')
analyzeTests = false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analyze tests or no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo was configured with <exclude-pattern>.*/test/.*</exclude-pattern>, which means the test code is likely littered with PMD violations. This setting effectively does the same thing.

We should fix this, but not now...

@LarsV123
LarsV123 merged commit 43a42e6 into main Nov 6, 2026
11 checks passed
@LarsV123
LarsV123 deleted the 2026-11-06-bump-dependencies branch November 6, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants