Repository navigation
ci: use publish instead of release - #9
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The only noted issue is a minor README setup-order nit that does not block approval.
Pull request overview
Replaces binary release automation with GHCR Docker image publishing and adds Docker Compose deployment support.
Changes:
- Adds a multi-stage Docker image and Compose agent service.
- Publishes tagged
linux/amd64images to GHCR. - Updates Docker documentation and excludes unnecessary build files.
- Removes the previous binary release workflow.
File summaries
| File | Summary |
|---|---|
README.md |
Documents Docker image usage and configuration. |
Dockerfile |
Builds the production agent image. |
compose.yaml |
Adds the GHCR-backed agent service. |
.github/workflows/release.yml |
Removes binary release publishing. |
.github/workflows/publish.yml |
Publishes tagged images to GHCR. |
.dockerignore |
Excludes secrets and unnecessary build context. |
Review details
Suppressed comments (1)
README.md:75
- Because
compose.yamlnow declares.envas a requiredenv_fileforagent, this command runs before.envis created in step 2. Compose validates that env file even when onlynapcatis targeted, so a fresh checkout can fail before NapCat starts. Create.envbefore this command and remove the duplicate setup in step 2.
docker compose up -d napcat
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.