Fix beta CI and test shared BTC vectors - #128
Merged
benma merged 2 commits intoAug 23, 2026
Merged
Conversation
benma-agent
force-pushed
the
benma-agent/shared-btc-test-vectors
branch
3 times, most recently
from
July 21, 2026 20:53
674f90e to
387fa40
Compare
benma
marked this pull request as ready for review
July 30, 2026 20:58
benma-agent
force-pushed
the
benma-agent/shared-btc-test-vectors
branch
3 times, most recently
from
August 23, 2026 18:31
3c20ed7 to
ecf368b
Compare
benma-agent
changed the title
Update async-trait to 0.1.92, which stops generating redundant #[must_use] attributes on async trait methods. This keeps Beta Clippy clean without downstream lint allowances.
Consume the PSBT transaction vectors introduced by BitBoxSwiss/bitbox02-firmware#2017 in simulator signing tests. The public PSBT API exercises conversion and the low-level signing protocol without a second raw fixture. Share stdout parsing and check versioned screens, errors, signature insertion, and final transactions. Teach PSBT signing to use output_script_configs for device-owned outputs from another account on firmware 9.22 and later, while preserving the older external-output behavior.
benma-agent
force-pushed
the
benma-agent/shared-btc-test-vectors
branch
from
August 23, 2026 18:43
ecf368b to
d865ab5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async-traitto 0.1.92 so Beta Clippy no longer sees generated redundant#[must_use]attributesThe fixture is byte-for-byte identical to firmware
pull/masterata3467ad11daee7081cc041ba9217c81e471022e6(SHA-2565baf824c2f7d39ce433bef04fbad655fe415c71933b0db7ca12c8993c400d8b7).Testing
cargo +stable test --tests --locked --features=simulator,tokio -- --nocapture --test-threads 1cargo +stable clippy --tests --locked --features=simulator,tokio -- -D warnings -A clippy::empty-docscargo +beta test --tests --locked --features=simulator,tokio -- --nocapture --test-threads 1cargo +beta clippy --tests --locked --features=simulator,tokio -- -D warnings -A clippy::empty-docsSIMULATOR=tests/simulators/bitbox02-multi-v9.26.5-simulator1.0.0-linux-amd64 cargo test --test test_btc_psbt --locked --features=simulator,tokio test_btc_transaction_vectors -- --nocapture --test-threads 1