Skip to content

Cover MAP parser validation and binary SELECT values - #132

Open
rohenaz wants to merge 1 commit into
masterfrom
test-map-parser-coverage
Open

Cover MAP parser validation and binary SELECT values#132
rohenaz wants to merge 1 commit into
masterfrom
test-map-parser-coverage

Conversation

@rohenaz

@rohenaz rohenaz commented Sep 9, 2026

Copy link
Copy Markdown
Member

Follow up on #131’s uncovered parser branches. Add regression tests for malformed base64, absent cells, binary keys and commands, SELECT parameter validation, and exact binary-value preservation through SELECT SET/ADD/DELETE/REMOVE. Also verify unrelated protocol tapes remain ignored.

Validation: go test -race -coverprofile=coverage.out ./... passes. The parser package now has 100% statement coverage locally. This is Go statement coverage, not a prediction of Codecov’s branch/partial-line calculation. Production parser behavior is unchanged.

@mergify mergify Bot assigned rohenaz Sep 9, 2026
@mergify mergify Bot added the test Unit tests, mocking, integration testing label Sep 9, 2026
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.27%. Comparing base (e100991) to head (aa8a661).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #132       +/-   ##
===========================================
+ Coverage   59.72%   90.27%   +30.55%     
===========================================
  Files           4        4               
  Lines         144      144               
===========================================
+ Hits           86      130       +44     
+ Misses         40       14       -26     
+ Partials       18        0       -18     
Flag Coverage Δ
unittests 90.27% <ø> (+30.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e100991...aa8a661. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Unit tests, mocking, integration testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant