ScrollView Rewrite - #1006
Draft
Mystin wants to merge 2 commits into
Draft
ScrollView Rewrite#1006Mystin wants to merge 2 commits into
Mystin wants to merge 2 commits into
Conversation
Created the edu.rpi.legup.ui.zoompane package. Created ZoomPane, ZoomPaneUI, ZoomBar, ZoomBarUI, ZoomViewport, ZoomView, and ZoomViewController (soon to replace Controller). ZoomPane is a JScrollPane subclass and maintains a ZoomBar and ZoomViewport. ZoomPane and ZoomBar have their own UI delegate classes and have distinct UI defaults. ZoomViewport uses a ZoomViewport.ZoomPeer as its Component view and as a peer to its new ZoomView. ZoomPeer is also where the ZoomViewController is installed, and provides a way to repaint areas of the ZoomView.
Rewrote most of edu.rpi.legup.ui.proofeditorui.treeview such that TreeView is now a ZoomView inside of a ZoomPane. Made some necessary controller and model adjustments to make the view behave as expected. Fixes: Bram-Hub#991 Bram-Hub#863
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current
ScrollViewis cobbled together in a way that works, but is not very intuitive, chafes against Java Swing's architecture, and does not look very clean or professional in practice. I have written a newZoomViewclass and several other related classes necessary for it to work cleanly in thezoomviewpackage. I have thus far implemented theTreeViewas aZoomPane, and am working on implementingBoardViewtoo.Closes #990
Closes #991
Type of change
How Has This Been Tested?
I have tested the zooming and hotkeys extensively on Windows, as well as ensuring that the popup notifications work and display in the correct place. The new
TreeViewaccurately displays nodes and transitions, including branching and merging transitions. The colors are pulled from the LookAndFeel.Checklist: