Fix outbox clear isolation between mediators#4242
Open
thomhurst wants to merge 1 commit into
Open
Conversation
Independent mediators can own different outboxes and must not suppress each other's nonblocking clear operation. Closes BrighterCommand#4241
thomhurst
requested review from
DevJonny,
holytshirt,
iancooper and
preardon
as code owners
July 18, 2026 21:29
iancooper
approved these changes
Jul 19, 2026
Contributor
Author
|
@iancooper Happy for me to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OutboxProducerMediatorinstanceRoot cause
The semaphore was static for each closed generic mediator type. A clear running on one mediator therefore caused another mediator with a different outbox to fail
WaitAsync(TimeSpan.Zero)and silently skip its own clear.Validation
Expected: 1,Actual: 0)Closes #4241