Skip to content

feat: migrate multiOmicDataSet object to MOObject - #1

Open
kelly-sovacool wants to merge 8 commits into
mainfrom
initial-plan
Open

feat: migrate multiOmicDataSet object to MOObject#1
kelly-sovacool wants to merge 8 commits into
mainfrom
initial-plan

Conversation

@kelly-sovacool

@kelly-sovacool kelly-sovacool commented Aug 28, 2026

Copy link
Copy Markdown
Member

Changes

This PR migrates the multiOmicDataSet object class into MOObject so downstream packages can depend on a lightweight package without requiring MOSuite.
MOObject is focused on class/IO responsibilities, while analysis/visualization behavior should remain in MOSuite.

Included in this PR:

  • Added core class implementation in R/multiOmicDataSet.R:
    • multiOmicDataSet S7 class definition
    • constructors from data frames and delimited files
    • object-level extract_counts generic + method
    • read/write RDS helpers
    • object property export helper (write_multiOmicDataSet_properties)
  • Added test coverage for constructor behavior, validation, count extraction, and IO round-trips.
  • Added migration planning document in .github/plans/initial-plan.md.

Issues

resolves CCBR/MOSuite#270

Generative AI Usage Statement

AI assistance was used to draft and migrate code/doc/test scaffolding, followed by manual review of all changes before submission.

  • Model: GPT-5.3-Codex
  • Prompt intent: move multiOmicDataSet class + object helpers into MOObject and keep package lightweight
  • Manual review: completed before opening PR

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • Update the docs if there are any API changes (roxygen2 comments, vignettes, readme, etc.).
  • Update NEWS.md with a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.html
  • Run devtools::check() locally and fix all notes, warnings, and errors.

@github-actions github-actions Bot added the MOObject RepoName label Aug 28, 2026
@kelly-sovacool kelly-sovacool added the AI-assisted PR includes AI-assisted content label Aug 28, 2026
@kelly-sovacool kelly-sovacool changed the title feat: migrate multiOmicDataSet object layer to MOObject feat: migrate multiOmicDataSet object to MOObject Aug 28, 2026
kelly-sovacool added a commit that referenced this pull request Aug 28, 2026
Add development-version NEWS entry for PR #1 covering class, IO, and test additions.

_AI assistance: GPT-5.3-Codex_
@kelly-sovacool
kelly-sovacool force-pushed the initial-plan branch 2 times, most recently from e072cbb to 1cd5b12 Compare August 28, 2026 22:07
ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

chore: update .gitignore from MOSuite

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

ci: 🤖 auto-format

docs(news): add changelog entry for object migration

Add development-version NEWS entry for PR #1 covering class, IO, and test additions.

_AI assistance: GPT-5.3-Codex_

chore: ignore detritus

chore: delete README.html
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@kelly-sovacool
kelly-sovacool marked this pull request as ready for review August 28, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-assisted PR includes AI-assisted content MOObject RepoName

Projects

Status: BackLog

Development

Successfully merging this pull request may close these issues.

Create MOObject package

1 participant