Repository navigation
feat: upstream feature batch B — CSV BOM, loop colors, images, terminology - #15
Merged
Merged
Conversation
… terminology - wireviz#98: CSV BOM output (-f c, output_formats="csv", <name>.bom.csv) - wireviz#457: loop colors, loops: [{RD: [VCC, SENSE]}] (syntax of upstream PR wireviz#288) - wireviz#460: options.show_title draws metadata.title above the diagram - wireviz#410: --disable-key / parse(disable_keys=...) drops an attribute from all components or one (X1.image) - wireviz#212, wireviz#453: cable show_box: false draws wires straight between connectors, without the cable box - wireviz#135, wireviz#271: CSS/HTML color names (tomato, lightgreen); WireViz codes still win, and no CSS name parses as a code sequence - wireviz#202: .webp images are converted to PNG before rendering - wireviz#188, wireviz#322: embedded data:image/...;base64 images (also in untrusted mode), decoded into a per-harness temp dir with the pixel cap - wireviz#331: options.terminology replaces pin/wire/shield (upstream PR wireviz#398) - wireviz#296: connector strip: {sleeve, insulation} (syntax of upstream PR wireviz#446) Also: titles and node names are passed as nohtml, so "<X>" is never read as an HTML label. CLAUDE.md records the YAML loading, escaping and edge-writing invariants.
# Conflicts: # tests/test_upstream_issues.py
- images: Pillow is told the declared format (data URI type, WEBP for .webp), so attacker bytes never reach other decoders such as EPS / Ghostscript; errors name the src as written, not the server path - a data URI or .webp used many times (YAML aliases) is decoded once per parse - show_title: backslashes in the title are literal (a trailing \ broke the render) - colored loops use the harness-wide padding, so they are as thick as wires - clear errors for a non-text loop color key and malformed terminology - terminology keeps the user's capitals after the first letter - docs: disable_keys uses the key under connectors:/cables:, the image limits, and why a .gv with converted images cannot be re-rendered
# Conflicts: # CLAUDE.md # src/wireviz/Harness.py # tests/test_security.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch B: small features from upstream wireviz/WireViz issues. Based on batch A; after batch A merges, the base moves to
master.-f c,output_formats="csv")loops: [{RD: [VCC, SENSE]}](syntax from upstream PR Loops by pin or pinlabel, loop color wireviz/WireViz#288)options.show_titledrawsmetadata.titleabove the diagram--disable-key image/X1.image, andparse(disable_keys=...)show_box: falsedraws wires straight between connectorslightgreen,tomato).webpimages are converted to PNGdata:image/...;base64images, also in untrusted modeoptions.terminologyfor pin/wire/shield (upstream PR Add options.terminology to override certain terms wireviz/WireViz#398)strip: {sleeve, insulation}(syntax from upstream PR Support stripping sleeve and insulation on Connector wireviz/WireViz#446)The review found two security issues; both are fixed:
Test plan
🤖 Generated with Claude Code