Repository navigation
feat(forum): accept a reserved username for the account that owns it - #931
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The forum SSO route accepts a reserved username only for the account that owns it (
reserved_username_owners, service-role only, in the private supabase repo). The table is read only when the stored username is on the reserved list. Everyone else still gets 409username_required.server/api/discourse/sso.post.ts: well-formed check, then the owner lookup for reserved names (read error → 503).shared/utils/usernames.ts:isWellFormedForumUsername().types/database.ts: regenerated (+22 lines: the new table andreserved_usernames()).Test plan
bun run test: 288 files, 6731 tests pass (3 new: owner signs in with the reserved name; owner read error → 503; non-reserved names never read the table)classicminidiy🤖 Generated with Claude Code