Skip to content

Validate FixedString sizes before swapping - #552

Merged
slabko merged 1 commit into
ClickHouse:masterfrom
fallintoplace:fix/validate-fixed-string-swap
Aug 24, 2026
Merged

Validate FixedString sizes before swapping#552
slabko merged 1 commit into
ClickHouse:masterfrom
fallintoplace:fix/validate-fixed-string-swap

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

What changed

  • Reject swaps between different FixedString sizes before changing either column.
  • Keep same-size swaps working as before.
  • Add coverage for both valid and invalid swaps.

Tests

  • cmake --build build --target clickhouse-cpp-ut --parallel 8
  • ./build/ut/clickhouse-cpp-ut --gtest_filter='ColumnsCase.*'

@slabko
slabko merged commit 8d928c9 into ClickHouse:master Aug 24, 2026
45 checks passed
@slabko

slabko commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Thank you @fallintoplace for noticing this inconsistency!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants