Repository navigation
MSPCA-30: Generalized Decorator for Strings - #14
Merged
shreeyaadhikari merged 9 commits intoOct 15, 2026
Merged
Conversation
shreeyaadhikari
marked this pull request as ready for review
October 14, 2026 22:24
dburkhart07
approved these changes
Oct 15, 2026
dburkhart07
left a comment
dburkhart07
left a comment
Collaborator
There was a problem hiding this comment.
all small things. super clean pr. actually goated
shreeyaadhikari
deleted the
sa/mspca-30-generalized-decorator-for-strings
branch
October 15, 2026 20:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes MSPCA-30
📝 Description
This PR adds a single reusable @IsNonEmptyString() decorator that trims the value and then validates it, so whitespace-only strings are rejected and padded strings are trimmed.
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
All backend tests pass.
🏕️ (Optional) Future Work / Notes