Skip to content

10 dev create tag module methods findbyid list find query list - #24

Merged
SamNie2027 merged 6 commits into
mainfrom
10-dev-create-tag-module-methods---findbyid-list-find-query-list
Oct 4, 2026
Merged

SamNie2027 merged 6 commits into
mainfrom
10-dev-create-tag-module-methods---findbyid-list-find-query-list

Conversation

@camila-carrillo

@camila-carrillo camila-carrillo commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

ℹ️ Issue

Closes #10

📝 Description

Added the retrieval methods needed for tags to be looked up by ID or category.

Briefly list the changes made to the code:

  1. Added an endpoint to retrieve a single tag by ID.
  2. Added an endpoint to retrieve multiple tags from a list of IDs.
  3. Added an endpoint to retrieve tags by category.
  4. Added validation for missing tag IDs and invalid categories.
  5. Added unit tests for successful retrievals, missing IDs, invalid categories, and empty ID lists.
  6. Added inline documentation for the new controller and service methods.

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Wrote and ran unit tests. Manually tested endpoints using Postman.

Screenshot 2026-09-28 221745 Screenshot 2026-09-28 221828 Screenshot 2026-10-03 142323 Screenshot 2026-10-03 150334

🏕️ (Optional) Future Work / Notes

@camila-carrillo camila-carrillo linked an issue Sep 27, 2026 that may be closed by this pull request
6 tasks
@SamNie2027

SamNie2027 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

We can delete tag.entity.ts, I probablt left that there by accident. I'll handle that

@SamNie2027
SamNie2027 self-requested a review September 28, 2026 17:20
@SamNie2027

Copy link
Copy Markdown
Collaborator
image

@SamNie2027

Copy link
Copy Markdown
Collaborator
image

@SamNie2027 SamNie2027 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this and finding that bug with the API testing! I totally missed it that bug so I appreciate you finding that.

I've requested minor changes, but some of the surface level API testing I've done may have revealed bugs. If you could review them and then re-request me as a reviewer, that would be great, thank you!

Comment thread apps/backend/src/tags/tags.service.ts Outdated
Comment thread apps/backend/src/tags/tags.service.ts Outdated
Comment thread apps/backend/src/tags/tags.service.spec.ts Outdated
Comment thread apps/backend/src/tags/tags.service.spec.ts Outdated
Comment thread apps/backend/src/tags/tags.service.spec.ts Outdated
Comment thread apps/backend/src/tags/tags.controller.ts
@SamNie2027

SamNie2027 commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Okay I think when I did the categories one I did that API test totally wrong, that's totally my bad

@SamNie2027

Copy link
Copy Markdown
Collaborator

The findById endpoint needs to be a GET endpoint, not a POST endpoint

@SamNie2027 SamNie2027 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing all of the feedback so quickly! I just have one request that I missed in my first review - the getTagsByIds is supposed to be a GET endpoint since the purpose of the endpoint is for retrieving data which is why my API test for that didn't succeed, since I was testing it as a GET endpoint.

@SamNie2027 SamNie2027 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the Type errors and then I think you should be good, thank you!
Disregard this I am on the wrong PR.

@SamNie2027 SamNie2027 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this!

@SamNie2027
SamNie2027 merged commit 87b299f into main Oct 4, 2026
4 checks passed
@SamNie2027
SamNie2027 deleted the 10-dev-create-tag-module-methods---findbyid-list-find-query-list branch October 4, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dev] Create Tag Module Methods - FindById (LIST), Find (query, list)

2 participants