10 dev create tag module methods findbyid list find query list - #24
SamNie2027 merged 6 commits into
Conversation
|
We can delete tag.entity.ts, I probablt left that there by accident. I'll handle that |
SamNie2027
left a comment
There was a problem hiding this comment.
Thank you for your hard work on this and finding that bug with the API testing! I totally missed it that bug so I appreciate you finding that.
I've requested minor changes, but some of the surface level API testing I've done may have revealed bugs. If you could review them and then re-request me as a reviewer, that would be great, thank you!
|
Okay I think when I did the categories one I did that API test totally wrong, that's totally my bad |
|
The findById endpoint needs to be a GET endpoint, not a POST endpoint |
There was a problem hiding this comment.
Thank you for addressing all of the feedback so quickly! I just have one request that I missed in my first review - the getTagsByIds is supposed to be a GET endpoint since the purpose of the endpoint is for retrieving data which is why my API test for that didn't succeed, since I was testing it as a GET endpoint.
SamNie2027
left a comment
There was a problem hiding this comment.
Thank you for your hard work on this!


ℹ️ Issue
Closes #10
📝 Description
Added the retrieval methods needed for tags to be looked up by ID or category.
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Wrote and ran unit tests. Manually tested endpoints using Postman.
🏕️ (Optional) Future Work / Notes