Manchester | 26-ITP-May | Abdu Hassen | Sprint 3 | Alarm Clock - #1334
Open
Abduhasen wants to merge 2 commits into
Open
Manchester | 26-ITP-May | Abdu Hassen | Sprint 3 | Alarm Clock#1334Abduhasen wants to merge 2 commits into
Abduhasen wants to merge 2 commits into
Conversation
Abduhasen
added
📅 Sprint 3
cjyuan
reviewed
Aug 3, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
What application states should be reset before starting a new countdown to ensure consistent behaviour between runs?
Note: a user may not click the "Stop" button first before starting a new count down.
Comment on lines
+4
to
+9
| const userInput = document.querySelector("#alarmSet").value; | ||
| let timeRemaining = Number(userInput); | ||
| if (isNaN(timeRemaining) || timeRemaining <= 0) { | ||
| alert("Please enter a valid number."); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Some input values that can make your app behave abnormally can still pass this check. Can you strengthen the check?
cjyuan
added
Reviewed
Abduhasen
added
Needs Review
cjyuan
reviewed
Aug 5, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. Well done.
Comment on lines
+8
to
+10
| isNaN(timeRemaining) || | ||
| timeRemaining <= 0 || | ||
| !Number.isInteger(timeRemaining) |
Contributor
There was a problem hiding this comment.
You could probably remove one of these checks as it is redundant.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
-wrote a function that takes positive number,set alarm,count down,play alarm at specific time
Questions
N/A