London | 26-ITP-May | Chinwe Chukwuma | Sprint 1 | Module-data-groups - #1341
Open
ChinweP wants to merge 7 commits into
Open
London | 26-ITP-May | Chinwe Chukwuma | Sprint 1 | Module-data-groups#1341ChinweP wants to merge 7 commits into
ChinweP wants to merge 7 commits into
Conversation
ChinweP
added
📅 Sprint 1
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work. This passes the tests.
I see one improvement to make.
Also, when I run the tests I get a notice about a test that is not done yet, can you resolve that?
| @@ -1 +1,5 @@ | |||
| function dedupe() {} | |||
| function dedupe(arr) { | |||
| return [...new Set(arr)]; | |||
| if (numbers.length === 0) { | ||
| return -Infinity; | ||
| } | ||
| return Math.max(...numbers); |
There was a problem hiding this comment.
Can you try implementing this without using the built-in max?
Author
There was a problem hiding this comment.
I've updated findMax to use a manual calculation instead of Math.max, and I removed the placeholder test.todo so all tests run successfully.
LonMcGregor
added
Reviewed
ChinweP
added
the
Needs Review
ChinweP
removed
the
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Sprint 1 of Module-data-groups complete following readme instructions