Skip to content

London | ITP-may-2026 | Mandip Sanger | Sprint 2 | Coursework - #1541

Open
mandipsanger wants to merge 16 commits into
CodeYourFuture:mainfrom
mandipsanger:sprint2
Open

London | ITP-may-2026 | Mandip Sanger | Sprint 2 | Coursework#1541
mandipsanger wants to merge 16 commits into
CodeYourFuture:mainfrom
mandipsanger:sprint2

Conversation

@mandipsanger

@mandipsanger mandipsanger commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Coursework for Sprint 2

@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger changed the title Module1- Sprint2 London | ITP-may-2026 | Mandip Sanger | Sprint 2 | Coursework Jul 22, 2026
@mandipsanger mandipsanger added 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 22, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 27, 2026
LonMcGregor
LonMcGregor reviewed Jul 27, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, a couple of files have things to update

Comment thread Sprint-2/3-mandatory-implement/2-cases.js Outdated
Comment thread Sprint-2/4-mandatory-interpret/time-format.js Outdated
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 27, 2026
LonMcGregor
LonMcGregor reviewed Aug 3, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task looks complete now, good work

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mandipsanger @LonMcGregor