London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Dead-Code - #1591
Open
russom-g wants to merge 2 commits into
Open
London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Dead-Code#1591russom-g wants to merge 2 commits into
russom-g wants to merge 2 commits into
Conversation
russom-g
added
the
Needs Review
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Sprint 3 looks good - but can you remove the unneeded files from Sprint 1? Thanks
LonMcGregor
added
Reviewed
Author
|
@LonMcGregor Files that don't belong here are removed. |
LonMcGregor
added
the
Needs Review
|
If you check the "files changed" tab here on github, you can see lots of files listed. Can you fix it so only the dead code ones are listed? You may want to check https://curriculum.codeyourfuture.io/guides/reviewing/fixing/ if you need a reminder on how to do this |
LonMcGregor
removed
the
Needs Review
russom-g
force-pushed
the
Sprint-3/3-dead-code
branch
from
August 3, 2026 19:57
adb19d8 to
7611916
Compare
Author
|
@LonMcGregor I removed the files. Hopefully it worked this time. |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Dead code that was not contributing the the function identified and removed.