Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Security patch
What is the current behavior?
See Transitive deps pull critical/high vulns on fresh install (protobufjs via @trezor/connect, axios via @reown/@coinbase) #104
What is the new behavior (if this is a feature change)?
Current published version (2.5.0):
699 pkgs installed → 33 vulns (1 crit, 7 high, 6 mod, 19 low)
This commit:
429 pkgs installed → 20 vulns (0 crit, 1 high, 6 mod, 13 low)
Other information:
There's two potential issues left. First, the last high vuln is from axios (@reown/appkit → optional @base-org/account@2.4.0 (hard-pinned) → @coinbase/cdp-sdk → axios@1.16.0). Fix needs ≥1.18.0; appkit 1.8.23 still pins the vulnerable chain. Second, Trezor's v10 line still has no stable release yet. I just bumped from alpha to beta pre-release. Type-checking passes, but I don't have one to test and none of the existing tests cover Trezor functions. You might want to add some mocking for
@trezor/connect-webto assert ongetAddresses()andsignTransaction()to make sure there aren't any API shifts.