Conversation
- add v9.3.9 changelog entry to whatsnew.md - document sort() reset-anew and multi-level smartSorting behavior for DataCollection/TreeCollection - document getSortingStates() per-level smartSorting guarantee - document filter()'s multi property, AND-combination with permanent filters, and no-rule reset behavior - document parse()/load() resetting sorting and non-permanent filters - update Grid guides (usage.md, data_loading.md) to match
- rule object's attributes (by, match, compare, multi) and the compare callback's parameters now use nested <ul><li> markers instead of <br/>- and <ol>- pseudo-lists, matching the outer list
- explain that a plain resetFilter() call does not drop a permanent
filter: it survives and is reapplied after parse()/load(), and
resetFilter({ permanent: true }) is needed to remove it
- applied consistently to DataCollection and TreeCollection filter()
docs and the Grid filtering guide
- use <code> tags for inline API name references in the Grid guide's
HTML param table, since raw HTML blocks don't render markdown
backticks
- merge the "no rule" case into the general replace-behavior sentence instead of a separate callout, and describe the permanent-filter/ new-rule combination in plainer terms - applied to DataCollection/TreeCollection filter() docs and the Grid filtering guide - remove the v9.3.9 changelog entries added for sort(), filter(), getSortingStates(), parse(), and load() across DataCollection and TreeCollection API pages, keeping only the descriptive notes
Sorokin-Oleg
requested changes
Aug 11, 2026
|
|
||
| Before updating DHTMLX to the latest version, please check the [Migration to Newer Versions](migration.md) guide to avoid possible breakdowns. | ||
|
|
||
| ## Version 9.3.9 |
Contributor
There was a problem hiding this comment.
@mafanya23 не смотрел в рамках данного PR. Подготовлю в рамках релизной задачи.
| // -> [{ by: "country", dir: "desc" }, { by: "population", dir: "desc" }] | ||
|
|
||
| @descr: | ||
| The array is ordered from the base sorting level to the last one added; do not modify it, as it is the array the collection sorts by, not a copy. |
… note - replace the v9.3.9 Updates/Fixes list in whatsnew.md with the full, reconciled set of entries (adds 5 previously undocumented fixes: forEach()/map() inconsistency, duplicated selection overlays, checkbox-click-triggers-sort, undefined CSS class with mark, grouped column close-icon starting a drag) - update the v9.3.9 release date to August 12, 2026 - drop the "do not modify the array" note from getSortingStates() docs (DataCollection, TreeCollection) and the matching sentence in the Grid sorting guide
- remove the "Multi-level sorting" section from DataCollection and TreeCollection sort() API pages, and the matching whatsnew.md Updates bullets for sort() and getSortingStates() - source sorting semantics for a bare sort() call while a smart base is in place have been changed and reverted more than once on the same day (DHX-5263); until that settles, drop the claims rather than document unstable behavior - revert the Grid multisorting guide (usage.md) example and wording back to the pre-9.3.9 form to match - parse()/load() reset behavior and other 9.3.9 entries are unaffected and stay as documented
- release date in whatsnew changed from August 12 to August 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.