Repository navigation
Update CI template tests for Assay workbook - #5
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be411ae2f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert not col_definitions.empty | ||
| assert initialise_welcome(init_info, TEMPLATES_DIR / template_name) is not None | ||
| welcome_metadata = initialise_welcome(init_info, TEMPLATES_DIR / template_name) | ||
| if any(sheet_name.lower() == "welcome" for sheet_name in init_info): |
There was a problem hiding this comment.
Restore welcome-sheet coverage
For the distributed templates that contain a welcome worksheet but do not list it in the Init table, this condition is false, so the test no longer asserts anything about welcome metadata. In that scenario initialise_welcome() can keep returning None, and converter() will skip setting SBOL_DICTIONARY, losing welcome fields such as Domain/Name/Master Collection without CI catching it. Please key the assertion off workbook sheet presence, or add welcome to Init, rather than using init_info as the gate.
Useful? React with 👍 / 👎.
Motivation
Study.xlsmworkbook; update the tests to point at the newAssay.xlsmtemplate and align expectations with the workbook's current sheets and welcome handling.Description
Study.xlsmwithAssay.xlsminTEMPLATE_SHEETSand require theAssayworkbook to includeassay,sample,measurement, andsignalsheets intests/test_templates.py.CONVERTIBLE_TEMPLATESto attempt SBOL conversion forAssay.xlsminstead ofStudy.xlsm.Initconfiguration explicitly lists awelcomesheet.Testing
python -m pytest -q tests/test_templates.pywhich passed (16 passed,9 warnings).python -m compileall -q src testswhich succeeded.python -m pip check, which reported an informational packaging version conflict due topackaging==21.3pinned by test deps while an existingblackinstallation requirespackaging>=22.0.Codex Task