Skip to content

Update CI template tests for Assay workbook - #5

Merged
Gonza10V merged 1 commit into
guifrom
codex/fix-ci-workflow-for-new-assay-template
Jul 23, 2026
Merged

Gonza10V merged 1 commit into
guifrom
codex/fix-ci-workflow-for-new-assay-template

Conversation

@Gonza10V

Copy link
Copy Markdown

Motivation

  • CI template tests targeted the removed Study.xlsm workbook; update the tests to point at the new Assay.xlsm template and align expectations with the workbook's current sheets and welcome handling.

Description

  • Replace Study.xlsm with Assay.xlsm in TEMPLATE_SHEETS and require the Assay workbook to include assay, sample, measurement, and signal sheets in tests/test_templates.py.
  • Update CONVERTIBLE_TEMPLATES to attempt SBOL conversion for Assay.xlsm instead of Study.xlsm.
  • Modify the welcome metadata assertion so the test only requires welcome metadata when the Init configuration explicitly lists a welcome sheet.

Testing

  • Ran python -m pytest -q tests/test_templates.py which passed (16 passed, 9 warnings).
  • Ran python -m compileall -q src tests which succeeded.
  • Ran python -m pip check, which reported an informational packaging version conflict due to packaging==21.3 pinned by test deps while an existing black installation requires packaging>=22.0.

Codex Task

@Gonza10V
Gonza10V merged commit 0c5364e into gui Jul 23, 2026
4 checks passed
@Gonza10V
Gonza10V deleted the codex/fix-ci-workflow-for-new-assay-template branch July 23, 2026 23:45

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be411ae2f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/test_templates.py
assert not col_definitions.empty
assert initialise_welcome(init_info, TEMPLATES_DIR / template_name) is not None
welcome_metadata = initialise_welcome(init_info, TEMPLATES_DIR / template_name)
if any(sheet_name.lower() == "welcome" for sheet_name in init_info):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore welcome-sheet coverage

For the distributed templates that contain a welcome worksheet but do not list it in the Init table, this condition is false, so the test no longer asserts anything about welcome metadata. In that scenario initialise_welcome() can keep returning None, and converter() will skip setting SBOL_DICTIONARY, losing welcome fields such as Domain/Name/Master Collection without CI catching it. Please key the assertion off workbook sheet presence, or add welcome to Init, rather than using init_info as the gate.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant