Support HEX colors for GeneProduct, Regulator, and Reporter - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#00FF00) for plotting and visualization.RegulatorandReporterpreserve and propagate caller-provided color values to the baseGeneProductfor consistent drawing behavior.Description
colorparameter insrc/loica/geneproduct.pydescribing Matplotlib-compatible values including HEX strings.Regulator.__init__to forwardcolorto the baseGeneProductinitializer via keyword arguments (sbol_compandcolor).Reporter.__init__to forwardcolorto the base initializer and removed a redundantself.colorassignment so the base class owns the value.type\_totype_and added unit tests intests/test_geneproduct.pyverifying HEX color preservation forGeneProduct,Regulator, andReporter.Testing
pytest tests/test_geneproduct.py tests/test_sbol_export.pywhich completed successfully.10 passed(test suite run shown as10 passed in 2.40s).Codex Task