Repository navigation
fix: preserve safe network diagnostics through budget recovery - #258
Merged
DavidHLP merged 4 commits intoOct 11, 2026
Merged
Conversation
DavidHLP
marked this pull request as ready for review
October 10, 2026 10:28
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb2587a9cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DavidHLP
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A real development evaluation stopped on a network/read failure, but wrapping the transport exception erased its diagnostic type. Preserve a safe diagnostic in newly written failure receipts while retaining the full unknown-liability envelope and blocking every later request.
Record only four exact native HTTPX connection/read error or timeout type names; every other exception, including a custom HTTPX subclass, becomes
transport_failure. Never persist exception messages, URLs or request contents. Existing halt reasons and retry behavior remain unchanged. Update the canonical development guide and bound corpus digest.Recovery accepts this optional field using the same five fixed strings. Legacy receipts may omit it; all other types and values remain rejected. This fixes the recovery-schema incompatibility raised in review.
Validation at
f047619d6053ca834a8f197f226dae72ea585ac7:No paid calls or retrospective modification of historical failure evidence occurred. This improves diagnostics for future failures and does not resolve the existing unknown usage or constitute formal model acceptance.