Repository navigation
Fix refresh game list while sorting breaks tables - #658
Merged
DavidoTek merged 3 commits intoOct 15, 2026
Merged
Conversation
this commit fixes Issue #656 where sorted game lists get corrupted when refreshing while sorting by name is active. It prepares two functions that reset the list and temporarily disables the sort during the update. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
fixes wrong variable name for temporarily disable sorting.
…e list - Suspend sorting with a context manager around the game list load so sorting is restored even if loading a launcher's games fails - Update the Steam compat tool and ProtonDB cells of the game that sent the signal instead of currentRow(), which is -1 after a refresh; ProtonDB results for games from before a refresh are ignored - Re-apply the active search after refreshing the game list Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 of 4 tasks
Contributor
|
yess, that's much better this way. Good work! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #656
See #656 and #657