Repository navigation
Name the pipelinetest subjects and data secrets in micrometres and run nightly again - #946
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are consistent across workflow configuration, action defaults, comparison behavior, and documentation.
0 open findings
What changed in this PR
Updates pipeline-test naming, reference secrets, nightly scheduling, and empty-directory comparisons.
Changes:
- Standardizes subject and secret names using micrometre resolutions.
- Restores nightly pipeline testing.
- Ignores archive-lost empty directories during comparisons.
| File | Description |
|---|---|
tools/compare_subjects.py |
Excludes empty directories from one-sided results. |
.github/workflows/pipelinetest.yaml |
Updates names, secrets, matrix, and schedule. |
.github/workflows/PIPELINETEST.md |
Documents the renamed secrets. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference data of the pipeline test is now the output of the released v2.6.0 image (
cpu-v2.6.0), produced by dispatching this workflow with that image. Runs on four different runner CPUs (AMD EPYC 7763, 9V74 and 9V45, Intel Xeon 8370C) produced identical outputs for each subject, and a build from source on this branch reproduces the reference exactly (0 of 171 files differ for1000um).With the reference regenerated:
1000umand0800um, which were already the artifact names. One name now serves as subject directory, artifact name, folder in the reference tarball and secret suffix, so the separateartifact-idin the matrix is gone.PIPELINETEST_IMAGE_HREF_1000um,PIPELINETEST_IMAGE_HREF_0800um,PIPELINETEST_TARGET_HREF_1000umandPIPELINETEST_TARGET_HREF_0800um, and point to copies of the inputs and references on our own server. They are in place, which is what the dispatches on this branch ran with.QUICKTEST_LICENSEkeeps its name for now.37 2 * * *). Nights on which the branch did not move still stop early, and Sundays still run as the weekly baseline with fresh dependencies.tools/compare_subjects.pyno longer reports empty directories as present on one side only. A fresh run always has the emptymri/tmpandmri/transforms/bak, while a reference made from a CI artifact cannot, because artifacts and archives do not keep empty directories; this alone turned an identical run into "drifted".