Skip to content

Add optional zero-margin screenshot layout - #114

Merged
kdiers merged 1 commit into
Deep-MI:devfrom
thomasrudolfschneider:feature/screenshots-zero-margin
Oct 6, 2026
Merged

kdiers merged 1 commit into
Deep-MI:devfrom
thomasrudolfschneider:feature/screenshots-zero-margin

Conversation

@thomasrudolfschneider

Copy link
Copy Markdown

Summary

Adds an opt-in zero-margin mode for screenshot grids.

The new flag:

--screenshots_zero_margin

removes outer margins and spacing between screenshot panels. The existing
layout remains unchanged by default.

The Python API exposes the same behavior through
screenshots_zero_margin=False, and createScreenshots() through
ZERO_MARGIN=False.

Backward compatibility

  • disabled by default;
  • existing screenshot output is unchanged unless explicitly enabled;
  • existing public positional parameters retain their indices;
  • no new dependency is required.

Validation

  • default rendering unchanged;
  • zero-margin 12 x 3 screenshot grid visually verified;
  • ruff check . passes;
  • codespell passes;
  • Sphinx documentation build with -W succeeds.

Closes #112

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Automatic tight layout can override the requested bounds, and the option is not propagated to all screenshot-producing modules.

Review effort: Balanced
Findings: 2 Medium severity

Open (2)
What changed in this PR

Adds opt-in zero-margin rendering for screenshot grids while preserving default layouts.

Changes:

  • Adds CLI and Python API configuration.
  • Applies explicit zero subplot margins and spacing.
  • Documents the new option.
File Description
README.md Documents the CLI flag.
fsqc/​fsqcMain.py Parses and propagates the setting.
fsqc/​createScreenshots.py Implements zero-margin layout.
doc/​Usage.rst Updates usage documentation.
DESCRIPTION.md Adds the option to the command reference.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread fsqc/createScreenshots.py
Comment thread fsqc/fsqcMain.py
@kdiers
kdiers merged commit 31b6c8f into Deep-MI:dev Oct 6, 2026
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: remove residual margins and spacing from screenshot grids

3 participants