Repository navigation
docs(readme): semantic_query is a search_graph parameter; team artifact is opt-in (#1297) - #2403
Merged
Merged
Conversation
…ct is opt-in (#1297) The Search section introduced `semantic_query` as if it were an MCP tool. It is a parameter of search_graph (the tool's input schema in src/mcp/mcp.c). The Team-Shared Graph Artifact section said the artifact is written whenever you index. `persistence` defaults to false. The Best tier is written only by index_repository with persistence: true. Without it, an index only refreshes an artifact that already exists (Fast tier; see export_after_publish in src/pipeline/pipeline.c), and that applies to any index, not just the watcher's. The issue's other points are already correct on main: - the 17 registered tools match the README; - trace_call_path is a real alias of trace_path; - check_index_coverage is documented; - NOT EXISTS { (f)<-[:CALLS]-() } is supported since 08b62f0. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two README statements still disagreed with the server:
semantic_queryis asearch_graphparameter, not a tool. The Search section now says so.persistencedefaults tofalse.index_repositorywrites.codebase-memory/graph.db.zst(Best tier) only withpersistence: true. Without it, an index only refreshes an artifact that already exists (Fast tier,export_after_publishinsrc/pipeline/pipeline.c). The paragraph and both tier bullets now match.The report's other points were already fixed on main (checked against the source):
TOOLS[];trace_call_pathis a real alias oftrace_path;check_index_coverageis in the tools table;NOT EXISTS { (f)<-[:CALLS]-() }example has been supported since 08b62f0 (covered bycypher_exists_no_callers).Docs only; no code change. Note: draft PR #1245 rewrites the same artifact paragraph, so whichever lands second needs a rebase.
Huge thanks to @melihemreguler for checking the README against the running server, and to @mindplay-dk for the follow-up catches. Thanks also to the author of the earlier attempt in #1315.
Fixes #1297