Skip to content

LIMS-2402: Mark proposal as inactive after end date - #1096

Open
ndg63276 wants to merge 3 commits into
masterfrom
improvement/LIMS-2402/mark-proposal-as-inactive-after-enddate
Open

ndg63276 wants to merge 3 commits into
masterfrom
improvement/LIMS-2402/mark-proposal-as-inactive-after-enddate

Conversation

@ndg63276

Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-2402

Summary:

The industry team are going to start populating the Proposal.endDate field. After that, shipments etc should not be able to be created, the same as if the proposal is closed.

Changes:

  • Use the Proposal.endDate field to mark the proposal as active or not
  • Update the store getters used on the navbar (and sidebar on mobile)

To test:

  • Go to a 'Closed' proposal (eg mx300), check there is a warning message in the main menu, and there is no 'Add Shipments' button on the /shipments page
  • Go to an active proposal (eg mx23694), check no message is displayed in the main menu, and there is an 'Add shipment' button.
  • Edit the Proposal.endDate on the active proposal to a date in the future, check nothing changes
  • Edit it again to a date in the past, check the warning message is displayed and the Add Shipments button is hidden
  • Check the warning message is displayed on a small browser window (emulating mobile)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant