Repository navigation
fix(ci): adapter npm publish must provide string spec - #12
Merged
Merged
Conversation
npm pkg set splits on dots, so pinning @drakkar.software/anchor wrote a nested object and npm publish failed with "must provide string spec". Set version from the tag only, like core. Skip versions already on npm so 3.4.0 adapters can publish after core succeeded.
Core 3.4.0 is already on npm; adapter 3.4.0 never published. Cut a patch so tagging v3.4.1 runs the fixed publish workflow.
Herklos
marked this pull request as ready for review
September 16, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
publish.ymlran this before adapter publish:npm pkg settreats.as nested keys. That wrote:instead of a string spec.
npx npm@latest publishthen failed withmust provide string spec. Core only setsversion, so it published. Adapters do not have adependenciesfield; they already havepeerDependencies["@drakkar.software/anchor"].Failed run: https://github.com/Drakkar-Software/Anchor/actions/runs/35108337568 (
v3.4.0).Fix
dependencies.workflow_dispatchso adapters can be published frommainwithout movingv3.4.0.After merge
Do not re-run the failed
v3.4.0jobs — they still use the old YAML from the tag. Frommain, run Actions → Publish TypeScript Packages → Run workflow. Core 3.4.0 will be skipped; both adapters should publish 3.4.0. No new tag required unless that dispatch is not used.No npm publish from this PR.