Skip to content

fix(ci): adapter npm publish must provide string spec - #12

Merged
Herklos merged 3 commits into
mainfrom
cursor/fix-adapter-publish-2964
Sep 16, 2026
Merged

Herklos merged 3 commits into
mainfrom
cursor/fix-adapter-publish-2964

Conversation

@Herklos

@Herklos Herklos commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Root cause

publish.yml ran this before adapter publish:

npm pkg set "dependencies.@drakkar.software/anchor=$VERSION"

npm pkg set treats . as nested keys. That wrote:

"dependencies": {
  "@drakkar": { "software/anchor": "3.4.0" }
}

instead of a string spec. npx npm@latest publish then failed with must provide string spec. Core only sets version, so it published. Adapters do not have a dependencies field; they already have peerDependencies["@drakkar.software/anchor"].

Failed run: https://github.com/Drakkar-Software/Anchor/actions/runs/35108337568 (v3.4.0).

Fix

  • Set version from the tag only (same as core). Do not rewrite dependencies.
  • Skip a version that is already on the registry so core 3.4.0 does not block adapters.
  • workflow_dispatch so adapters can be published from main without moving v3.4.0.

After merge

Do not re-run the failed v3.4.0 jobs — they still use the old YAML from the tag. From main, run Actions → Publish TypeScript Packages → Run workflow. Core 3.4.0 will be skipped; both adapters should publish 3.4.0. No new tag required unless that dispatch is not used.

No npm publish from this PR.

Open in Web Open in Cursor 

npm pkg set splits on dots, so pinning @drakkar.software/anchor wrote a
nested object and npm publish failed with "must provide string spec".
Set version from the tag only, like core. Skip versions already on npm
so 3.4.0 adapters can publish after core succeeded.
Core 3.4.0 is already on npm; adapter 3.4.0 never published. Cut a patch
so tagging v3.4.1 runs the fixed publish workflow.
@Herklos
Herklos marked this pull request as ready for review September 16, 2026 15:11
@Herklos
Herklos merged commit ded0b1d into main Sep 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant