Repository navigation
Fix Bug/324 annotation icons centering - #325
Draft
DennisFriedl wants to merge 96 commits into
Draft
DennisFriedl wants to merge 96 commits into
DennisFriedl wants to merge 96 commits into
Conversation
# Conflicts: # resources/js/edirom-verovio-renderer
Veroviointegration
…ure not showing with high measure count
…r.js since the diglib logic is now included in OpenSeaDragonViewer.js
Edirom#275) * Remove FontAwesome dependency from edirom-image-viewer by making annotation stylesheet injection and category icons fully host-driven; closes Edirom#271. * populate iconHtml for the beschreibung/rasurTektur annotation zones when building zones-data * remove OpednSeadragon from resources and update the styling of annotations
…m-Online-Frontend into image-component-integration
[ftr]: ImageViewer host wiring into a shared helper
…tegration # Conflicts: # app/controller/window/source/SourceView.js # app/view/window/image/ImageViewer.js # app/view/window/image/OpenSeaDragonViewer.js # app/view/window/source/MeasureBasedView.js # app/view/window/source/PageBasedView.js # app/view/window/source/SourceView.js # app/view/window/text/TextFacsimileSplitView.js
hizclick
reviewed
Oct 28, 2026
hizclick
left a comment
hizclick
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @DennisFriedl. Has this also been tested on klarinettenquintett?
DennisFriedl
marked this pull request as draft
October 29, 2026 09:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on this PR #219 which needs to be approved first.
It makes changes to the CSS to center the annotation icons correctly.
These now look like this: