chore: stop tracking .java-version - #45
Merged
Merged
Conversation
The jenv pin names an exact JDK patch release, so it goes stale on every brew upgrade and differs between machines. It is developer-local state, not a project contract. CI is unaffected: ci.yml pins temurin@21 directly via actions/setup-java rather than reading java-version-file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.java-versionfrom version control. It pins an exact JDK patch release (21.0.6), which goes stale on everybrew upgradeand differs between machines — developer-local state, not a project contract./.java-versionto.gitignore, anchored to the repo root to match the existing rule style (/.claude,/.bsp)..gitignorewith a newline. Cosmetic; git parses an unterminated final line correctly either way.The file stays on disk for local jenv use — this only stops git tracking it.
Test plan
sbt githubWorkflowCheckpasses locally —ci.ymlstill matchesbuild.sbtci.ymlpinsjava-version: 21directly viaactions/setup-java, notjava-version-file:git check-ignoreconfirms both/.java-versionand/.clauderesolvejenv versionin the repo still reports21from the on-disk file