Add an amount argument to the minion give command - #3
Open
Crispi2k24 wants to merge 1 commit into
Open
Crispi2k24 wants to merge 1 commit into
Crispi2k24 wants to merge 1 commit into
Conversation
Crispi2k24
force-pushed
the
feature/give-amount
branch
from
September 23, 2026 15:06
0134cb4 to
d151d7e
Compare
Crispi2k24
force-pushed
the
feature/give-amount
branch
from
September 23, 2026 15:10
d151d7e to
7b35a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/minions give <type>takes an optional amount:/minions give miner 10. The two existing forms keep working and now route through the same method with an amount of one.MinionItemFactory#creategained an overload that takes the amount.Why
Handing out more than one minion meant repeating the command, which is tedious when setting up a server or paying out a reward.
Minion items carry no per-item data, so they stack, and
Inventory#addItemalready splits an oversized stack across slots. The amount therefore belongs on the item the factory builds - the factory owns how a minion item is put together, including how many of it there are - and the command stays a singleaddItemcall.Testing / notes
./gradlew buildpasses. Verified on a Purpur 26.2 server:/minions give miner 10gives ten across stacks,/minions give minerstill gives one,/minions givestill gives one of the default type, and an unknown type still reports the same message as before.