[WIP] Dedupe getTransactionsForReport lookups in Search row Action column - #97877
Draft
TMisiukiewicz wants to merge 1 commit into
Draft
[WIP] Dedupe getTransactionsForReport lookups in Search row Action column#97877TMisiukiewicz wants to merge 1 commit into
TMisiukiewicz wants to merge 1 commit into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
useLiveRowCapabilitiesruns per Search list row. For report rows it calledgetTransactionsForReport(data, reportID)twice per render — once insidegetActionsand again insidegetPrimaryAction. Each call scans every key of the search snapshot, so fast-scrolling the expenses list burned significant JS time re-deriving the same result for every visible row and produced blank rows.Fix:
getTransactionsByReportID(data)inSearchUIUtilsgroups the snapshot's transactions byreportIDin one pass (same grouping rule already used byprocessTransactionEntryinsideclassifyAndPreprocess).SearchResultsProvidercomputes it once per snapshot and exposescurrentSearchTransactionsByReportIDon the existingSearchResultsContext(React Compiler memoizes it ondataidentity, so it recomputes only when the snapshot changes).getActions(via the already-existing but previously unusedprecomputedTransactionsForReportparam) and togetPrimaryAction(new optional param with the same name).No behavior change:
useLiveRowCapabilitiescall sites (ExpenseReportListItem,TransactionListItem,TransactionGroupListItem) already source theirsnapshotDatafrom the sameuseSearchResultsContext(), so the map is derived from identical data.getTransactionsForReportis kept as the fallback when no precomputed array is supplied, so every other caller and the empty-map case behave exactly as before.getActionsuses[transaction]for transaction entries andgetPrimaryActionskips the lookup entirely.Test-only churn:
MockSearchContextProviderand sixtests/ui/*ListItemHeaderTest.tsxfiles constructSearchResultsContextValueby hand, so they each needed the new field;useLiveRowCapabilitiesTestneededuseSearchResultsContextadded to its@components/Search/SearchContextmock.This PR stands alone off
main.Fixed Issues
$
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari