Frontend decoupling and such for the eSim tool-manager#608
Open
caveman210 wants to merge 7 commits into
Open
Conversation
…ve dead code and comments
There was a problem hiding this comment.
Pull request overview
This PR introduces a toolManager/qt/ subpackage intended to decouple/organize Qt UI entrypoints and provide “adapter” modules for alternate module layouts, while also refactoring platform detection and tool category lists to rely on centralized toolManager.constants and toolManager.registry.
Changes:
- Added
src/toolManager/qt/adapter modules (main.py,gui_fixed.py,worker.py,updater_gui.py, plus package init) to re-export existing UI classes/utilities. - Refactored
src/toolManager/main.pyto importIS_WINDOWSand deriveANALOG_TOOLS/DIGITAL_TOOLSfromregistry.CATEGORIES. - Refactored
src/toolManager/gui_fixed.pyto usetoolManager.constantsforIS_WINDOWS/IS_LINUXinstead ofplatform.system().
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/toolManager/qt/worker.py | Adds a Qt worker adapter with fallback implementations for missing modules. |
| src/toolManager/qt/updater_gui.py | Adds an adapter that re-exports the updater window entrypoints. |
| src/toolManager/qt/main.py | Adds an adapter entrypoint and derives tool groupings/labels from the registry. |
| src/toolManager/qt/gui_fixed.py | Adds an adapter re-exporting the canonical GUI classes and platform constants. |
| src/toolManager/qt/init.py | Introduces the qt subpackage. |
| src/toolManager/main.py | Switches platform checks and tool lists to centralized constants/registry categories; minor cleanup. |
| src/toolManager/gui_fixed.py | Switches platform detection to toolManager.constants (fallback supported). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+4
| from toolManager.main import ToolManagerWindow, main | ||
| from toolManager.registry import TOOLS, CATEGORIES | ||
| from toolManager.constants import IS_WINDOWS | ||
| from toolManager.qt.gui_fixed import ToolManagerGUI |
Comment on lines
+1
to
+4
| from toolManager.gui_fixed import ToolManagerGUI, UninstallWindow, CommandWorker | ||
| from toolManager.registry import TOOLS | ||
| from toolManager.constants import IS_WINDOWS, IS_LINUX | ||
| from toolManager.paths import get_toolmanager_root |
Comment on lines
+1
to
+2
| from toolManager.updater_gui import PackageUpdaterWindow, main | ||
| from toolManager.registry import TOOLS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Purpose
Frontend decoupling for toolManager — extract Qt UI components into a dedicated qt/ subpackage, refactor platform detection and tool lists to use centralized constants and registry, and add try/except-guarded adapter files for cross-branch compatibility.
Approach