Repository navigation
images test: stop timing a busy machine in the drain test - #155
Merged
Merged
Conversation
The case gave a run 2 s against a 3 s bound, and failed under load. It now allows far more than a run takes, and still far less than the bound or the process left behind, so only the behaviour under test can fail it. Signed-off-by: Yi-Ru Lin <deduce@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the EC2 drain-test timing adjustments.
No open issues 🎉
What changed in this PR
This PR reduces timing sensitivity in the EC2 runner’s drain test to avoid failures under load and resulting mutate.sh INVALID results.
Changes:
- Raises both elapsed-time limits to 6 seconds.
- Extends the marker case’s drain bound from 3 to 30 seconds, keeping the assertion limit below that bound and the lingering process’s 8-second lifetime.
- Updates the comment explaining the timing margins.
| File | Description |
|---|---|
images/test-ec2-run.sh |
Adjusts drain-test timing thresholds and documents their rationale. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-ec2-run.shfailed under load on a 2 s limit, which also mademutate.shreport INVALID. The limit is now far above a run's time and far below the 30 s bound and the 8 s process left behind, so only the behaviour under test can fail it.