Repository navigation
scripts: run cache-protocol in make check; portable changelog tests - #217
Merged
Merged
Conversation
CI's cache-protocol job, the real @actions/cache toolkit against cache-server, ran only in CI, so a change to job identity reached a PR before its fixture broke. make check now runs it whenever test/cache-protocol's toolkit is installed, and says how to install it when not. test-changelog.sh matched multi-line text with grep -z and a \n in the pattern, which BSD grep reads as a newline and GNU grep does not. It now folds newlines on both sides. Signed-off-by: Yi-Ru Lin <deduce@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps in
make checkthat let breakage reach a PR or a Linux host:cache-protocolran only in CI. This job runs the real@actions/cachetoolkit against a freshly built cache-server. cacheserver: scope entries by repository ID as well as name #216 changed job identity, the job's fixture broke, and nobody found out until CI ran.make checknow runs it whenevertest/cache-protocol's toolkit is installed. When it is not installed, the check reports SKIP along with thenpm cicommand that installs it.scripts/test-changelog.shfailed on GNU grep. It matched multi-line text withgrep -zand a\nin the pattern. BSD grep reads that\nas a newline; GNU grep 3.12 does not. It turned up whencheck-remoteran on a Linux host. The test now folds newlines on both sides, and passes on macOS and on GNU grep 3.12.AGENTS.md is updated to match.