Repository navigation
feat(governance): ask the area steward for a review on pull requests that touch the area - #2019
Merged
Merged
Conversation
…that touch the area Signed-off-by: Felipe Marzochi <fmarzochi@gmail.com>
Signed-off-by: Felipe Marzochi <fmarzochi@gmail.com>
|
❌ The last analysis has failed. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Fmarzochi
added a commit
that referenced
this pull request
Oct 24, 2026
…ted, since a personal repository has no triage level (#2021) GitHub grants the triage permission on organization-owned repositories only, and a formal review request needs a collaborator; EGC is a personal repository, so the steward wiring of #2019 could not reach the accepted steward and two documents promised a level that does not exist here. The workflow now mentions the stewards it could not request in one comment per pull request (marker <!-- steward-review -->), docs/governance/stewards.md and docs/MAINTAINERS.md say the role carries no repository access, and the test checks the mention path. Signed-off-by: Felipe Marzochi <fmarzochi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Discussion #1442 opened area stewardship on 12 September and
docs/governance/stewards.mdrecords @Akisolu as the Windows and OpenCode steward since 14 September, but nothing in the repository carried the role:CODEOWNERSstayed* @Fmarzochi, no workflow asked the steward for a review (zero pull requests withreview-requested:Akisoluin forty days), the steward had read permission only, and Windows had no label to triage by.What changes
.github/stewards.json: the machine-readable twin of the stewards table, with the paths of each area (Windows and OpenCode accepted; Session Mesh and Installer invited).scripts/ci/request-steward-review.js: given the changed files, the author and the reviewers already requested, prints the accepted stewards to ask, one per line. Globs take**,*and?and ignore case; a steward is never asked on their own pull request; an invited area asks nobody..github/workflows/steward-review.yml: onpull_request_target(opened, reopened, ready for review) it checks out the base branch only, lists the pull request's files and requested reviewers throughgh api, runs the script and requests the reviews. A steward who is not yet a collaborator produces a warning, not a failure, so no pull request goes red over it.docs/governance/stewards.mdgains "How the role is wired" (the review automation, thetriagepermission, the labels of each area);docs/MAINTAINERS.mdnames the permission level instead of "without elevated access".platform: windowsexists in the repository since this evening, next totool: opencode.Verification
node tests/ci/request-steward-review.test.js: 11 passed (globs, the author exclusion, invited areas, reviewers already requested, the CLI and its usage errors, the JSON against the table in the same order, an accepted area matching tracked files, the workflow's trigger, permissions and base-only checkout).node scripts/ci/validate-workflow-security.js: 23 workflows validated;tests/ci/validate-workflow-security.test.js: 11 passed.npx eslinton the script and the test: clean; the local pre-push gate: eslint 0, Sonar 0, duplication 0.What stays with the maintainer
The
triagepermission for @Akisolu is a collaborator invitation only the maintainer sends; until it is accepted the workflow logs a warning where it would request the review.Summary by cubic
Makes the area steward role real: pull requests touching a stewarded area now automatically request a review from that area's accepted steward instead of going only to the maintainer.
.github/stewards.json(each area's paths and steward status) and a script that maps changed files to the stewards to ask, skipping the PR author and reviewers already requested.pull_request_target, checks out the base branch only, and warns instead of failing when a steward is not yet a collaborator.docs/ROADMAP.md, andCHANGELOG.md; spells out thetriagepermission and the area labels.triagecollaborator invitation to accepted stewards.Written for commit a19afd0. Summary will update on new commits.