fix(quorum): count enabled bitmap bits, not committee size, in pre-staking quorum check - #7
Open
Frozen wants to merge 1 commit into
Open
fix(quorum): count enabled bitmap bits, not committee size, in pre-staking quorum check#7Frozen wants to merge 1 commit into
Frozen wants to merge 1 commit into
Conversation
…taking quorum uniformVerifier.IsQuorumAchievedByMask compared the full committee size (len(mask.Publics)) against the threshold instead of counting bits actually set in the signer bitmap. An all-zero bitmap paired with an all-zero (identity) aggregate BLS signature therefore satisfied quorum for any pre-staking-epoch committee, since len(mask.Publics) always exceeds the threshold regardless of how many signers were enabled. Count enabled bits via mask.IndexEnabled and reject a nil mask outright. Add regression coverage: a mask-level table test for zero/below-threshold/ at-threshold/padding-bit bitmaps, and an engine-level test asserting that verifySignature rejects an empty pre-staking quorum end-to-end.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same fix as #6, cherry-picked (91ebee0) onto `main` for deployment there.
Fix
Count enabled bits via `mask.IndexEnabled`, reject a `nil` mask outright, before comparing against the threshold.
Test plan
🤖 Generated with Claude Code