Show what an allotment upload actually did, and mark summer rows - #304
Merged
vikrantwiz02 merged 1 commit intoAug 27, 2026
Merged
Conversation
A bulk allotment reported plain success even when the backend had skipped rows, and a partial upload came back as 2xx so the office was told everything worked. The notification now reports how many rows were allotted against how many were skipped, and carries the reason the backend gives for each failing row along with the first row number, staying open long enough to be read. The registered-courses table printed a bare semester number for every row, so a summer registration was indistinguishable from the regular one in the term it anchors to. Summer rows now read as such.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things the Allot Courses screen was hiding.
A partial upload was reported as a clean success. The backend answers 207 when some rows are skipped, which axios treats as a success, so the office saw
Allotted successfullywhile rows had been dropped. The notification now distinguishes the two: on a partial upload it reports how many rows were allotted against how many were skipped, and on a failure it carries the reason the backend gives for the failing rows plus the first row number. Both stay open long enough to be read, instead of auto-closing.A summer registration looked identical to the regular one. A summer term has no semester of its own and anchors to the adjacent one, so the registered-courses table printed the same bare semester number for both. Summer rows now read
4 (Summer), matching how the examination module labels them. The semester picker already separated the two, so only the row itself needed the marker.425 tests passing,
lint:strictclean.