[DSL] Aerosol Activation code

[CharlesKrop]

This PR brings in NDSL neural network aerosol activation code. An associated translate test ensures passes, ensuring Fortran - NDSL equivalence. Integration into MoistGridComp will come at a later time.

[romanc]

An associated translate test ensures passes, ensuring Fortran - NDSL equivalence.

Should we take this opportunity and move some infrastructure code from PR #1396 here to run this translate test as part of (subsequent) PRs?

[romanc]

An associated translate test ensures passes, ensuring Fortran - NDSL equivalence.

Should we take this opportunity and move some infrastructure code from PR #1396 here to run this translate test as part of (subsequent) PRs?

I just grabbed the branch and added basic NDSL linting. No clue where the translate test data is, so I skipped that part, but at least linting is now running.

[romanc]

@sdrabenh quick question: why do you keep pushing develop into this branch? I mean, yes, we'll need to update eventually, but for now, we don't need anything from develop. I'm obviously new here, so I'm just asking out of curiosity because

1. it seems a bit wasteful (every merge from develop triggers a pipeline run)
2. I'm used to a mode of working where feature branches belong to the ones opening the branch and nobody is pushing unsolocited commits to random feature branches.

[sdrabenh]

@sdrabenh quick question: why do you keep pushing develop into this branch? I mean, yes, we'll need to update eventually, but for now, we don't need anything from develop. I'm obviously new here, so I'm just asking out of curiosity because

1. it seems a bit wasteful (every merge from develop triggers a pipeline run)
2. I'm used to a mode of working where feature branches belong to the ones opening the branch and nobody is pushing unsolocited commits to random feature branches.

@romanc apologies for not seeing this message earlier.

1. The develop branch must be merged into this pull request prior to a final merge. Given development has been occurring at a rapid pace, there is a much greater chance of conflicts arising if the pull request is not kept current and allowed to become stale. If that occurs, I will kick it back to you to sort out conflicts rather than merging when I have the chance.
2. If you want a static branch to work on, then do not make a pull request - or at least make it a draft pull request. In those cases, I will not touch your branch. An official pull request signals the code is ready for review and merging. At that point, yes, develop/main will be synced as part of the workflow.

Happy to chat over Teams if you have more questions

[romanc]

@sdrabenh quick question: why do you keep pushing develop into this branch? I mean, yes, we'll need to update eventually, but for now, we don't need anything from develop. I'm obviously new here, so I'm just asking out of curiosity because

1. it seems a bit wasteful (every merge from develop triggers a pipeline run)
2. I'm used to a mode of working where feature branches belong to the ones opening the branch and nobody is pushing unsolocited commits to random feature branches.

@romanc apologies for not seeing this message earlier.

1. The develop branch must be merged into this pull request prior to a final merge. Given development has been occurring at a rapid pace, there is a much greater chance of conflicts arising if the pull request is not kept current and allowed to become stale. If that occurs, I will kick it back to you to sort out conflicts rather than merging when I have the chance.

2. If you want a static branch to work on, then do not make a pull request - or at least make it a draft pull request. In those cases, I will not touch your branch. An official pull request signals the code is ready for review and merging. At that point, yes, develop/main will be synced as part of the workflow.

Happy to chat over Teams if you have more questions

Thanks for the reply and the detailled answer. As said, we are new to this repo and just need to learn how things get done around here. I forgot this PR wasn't in draft state. It is indeed not yet ready for show. I've put it back into draft state.

[sdrabenh]

@sdrabenh quick question: why do you keep pushing develop into this branch? I mean, yes, we'll need to update eventually, but for now, we don't need anything from develop. I'm obviously new here, so I'm just asking out of curiosity because

1. it seems a bit wasteful (every merge from develop triggers a pipeline run)
2. I'm used to a mode of working where feature branches belong to the ones opening the branch and nobody is pushing unsolocited commits to random feature branches.

@romanc apologies for not seeing this message earlier.

1. The develop branch must be merged into this pull request prior to a final merge. Given development has been occurring at a rapid pace, there is a much greater chance of conflicts arising if the pull request is not kept current and allowed to become stale. If that occurs, I will kick it back to you to sort out conflicts rather than merging when I have the chance.

2. If you want a static branch to work on, then do not make a pull request - or at least make it a draft pull request. In those cases, I will not touch your branch. An official pull request signals the code is ready for review and merging. At that point, yes, develop/main will be synced as part of the workflow.

Happy to chat over Teams if you have more questions

Thanks for the reply and the detailled answer. As said, we are new to this repo and just need to learn how things get done around here. I forgot this PR wasn't in draft state. It is indeed not yet ready for show. I've put it back into draft state.

No problem. Thanks for letting me know. I can definitely see how it could be frustrating to be getting pushes if you thought it was in draft state. I'll ignore for now until you are ready. Thanks.

[FlorianDeconinck]

@sdrabenh : this is ready to go in, no changes to the Fortran, this brings a first version of the DSL Aerosol Activation code ported from Fortran

[romanc]

@GEOS-ESM/gcm-gatekeepers: this is ready to be merged