Skip to content

fix: redact RNG seed from HTTP response logging in release builds - #550

Merged
x64-dev merged 1 commit into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/mask-seed
Aug 8, 2026
Merged

fix: redact RNG seed from HTTP response logging in release builds#550
x64-dev merged 1 commit into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/mask-seed

Conversation

@tintinhamans

Copy link
Copy Markdown

HTTPRequest::Threaded_SetComplete logs the raw body of every HTTP response.
GET /Lobby/{id} and GET /Lobbies both serialize the full Lobby object, so
each response carries RNGSeed — one per entry for the lobby list. The seed for
a match ends up in GeneralsOnline.log in the clear before the game starts, and
that has avenues for potential abuse.

Signed-off-by: tintinhamans <5984296+tintinhamans@users.noreply.github.com>
@tintinhamans tintinhamans changed the title Redact RNG seed from HTTP response logging in release builds fix: redact RNG seed from HTTP response logging in release builds Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⚠️ Title/Commit Validation Failed

Invalid PR title:

  • fix: redact RNG seed from HTTP response logging in release builds

Invalid commit messages:

  • Redact RNG seed values from HTTP response for security
    PR titles and commit messages must follow conventional commits format:
type: Description
type(scope): Description

Allowed types: bugfix, build, chore, ci, docs, fix, feat, perf, refactor, revert, style, test, tweak, unify

See CONTRIBUTING.md for details.

@x64-dev
x64-dev merged commit d66d841 into GeneralsOnlineDevelopmentTeam:main Aug 8, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants