fix(w3ddevice): Add null check for tree tile RGB data in W3DTreeBuffer::drawTrees - #552
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
fix(w3ddevice): Add null check for tree tile RGB data in W3DTreeBuffer::drawTrees#552seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a fatal
EXCEPTION_ACCESS_VIOLATION_READcrash occurring inW3DTreeBuffer::drawTrees.Root Cause:
The
W3DTreeTextureClass::updatefunction (inlined intodrawTrees) callspTile->getRGBDataForWidth(). This method can return a null pointer if the tile's RGB data is unavailable. The subsequent code then dereferenced this potentially null pointer within a loop without any null check, leading to a crash.Fix:
pTile->getRGBDataForWidth(tilePixelExtent)has been hoisted outside the innerjloop, as its return value is constant for a given tile.if (!pTileRGB) continue;) has been added immediately after the call togetRGBDataForWidth(). If the returned pointer (pTileRGB) is null, the processing for the current tile is skipped, preventing the dereference of a null pointer.pBGR(the per-row pointer offset) now correctly uses thepTileRGBbase pointer within thejloop.This change ensures that the application gracefully handles cases where tree tile RGB data might be missing or uninitialized, preventing crashes during tree rendering.
Fixes CLIENT-2Z9