Fix double scaling when exporting Gemma embeddings - #1
Open
ybochkov wants to merge 1 commit into
Open
Conversation
PartlyFrozenEmbeddings.to_embeddings() previously rebuilt the embedding table by calling self.forward() for every token. Gemma's specialized wrapper applies embed_scale in forward(), so the exported checkpoint contained already-scaled vectors. Gemma then applied the same scale again at inference time after loading the checkpoint. Reconstruct the standard embedding table directly from the frozen and trainable parameter partitions instead. Preserve the source padding index and dtype while rebuilding the layer. Add regression tests that distinguish runtime Gemma scaling from persisted raw weights and verify that ordinary embedding reconstruction retains weights and metadata.
ybochkov
force-pushed
the
fix/double-scaling
branch
from
August 12, 2026 14:56
7d947f3 to
5deee77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PartlyFrozenEmbeddings.to_embeddings()previously rebuilt the embedding table by callingself.forward()for every token. Gemma's specialized wrapper appliesembed_scaleinforward(), so the exported checkpoint contained already-scaled vectors. Gemma then applied the same scale again at inference time after loading the checkpoint.Reconstruct the standard embedding table directly from the frozen and trainable parameter partitions instead. Preserve the source padding index and
dtypewhile rebuilding the layer.Add regression tests that distinguish runtime Gemma scaling from persisted raw weights and verify that ordinary embedding reconstruction retains weights and metadata.