Skip to content

[Bugfix] 修复未受支持的模组加载器标签在模组版本界面不显示 - #6289

Merged
Glavo merged 33 commits into
HMCL-dev:mainfrom
ToobLac:fix-6280
Sep 8, 2026
Merged

[Bugfix] 修复未受支持的模组加载器标签在模组版本界面不显示#6289
Glavo merged 33 commits into
HMCL-dev:mainfrom
ToobLac:fix-6280

Conversation

@ToobLac

@ToobLac ToobLac commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Fixes #6280

@ToobLac ToobLac changed the title [Bugfix] 修复未受支持的模组加载器标签在模组版本界面不现实 [Bugfix] 修复未受支持的模组加载器标签在模组版本界面不显示 Jul 2, 2026
@ToobLac
ToobLac marked this pull request as ready for review July 2, 2026 10:09
Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/util/Either.java Outdated
@ToobLac
ToobLac marked this pull request as draft July 2, 2026 13:54
@ToobLac
ToobLac marked this pull request as ready for review July 2, 2026 14:24
@CHN-Nine9

Copy link
Copy Markdown

@ToobLac 请认真审阅 issue 正文内容,当前状态仅解决了 #6280

image

#6279 的问题并没有得到解决,请仔细查看详细部分的正文内容,不得一同关闭!

image

模组下载模组列表使用的不是同一套识别逻辑,因此 #6280#6279 不是同一个问题。

对于你提及

开了bug就不要开feature了

不存在重复问题。

@ToobLac

ToobLac commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

#6279 的问题并没有得到解决,请仔细查看详细部分的正文内容,不得一同关闭!

My fault. 6279我现在暂时不打算做,可能后面会开一个pr,跟多加载器模组一起实现

@Glavo

Glavo commented Jul 3, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0e31c1def

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/LocalModFile.java Outdated
@Glavo

Glavo commented Jul 3, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47dd87788f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/util/Either.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java Outdated
@ToobLac ToobLac mentioned this pull request Jul 5, 2026
5 tasks
@Glavo

Glavo commented Jul 8, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6b3b87824

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/util/Either.java Outdated
@github-actions github-actions Bot added the 100+ label Jul 17, 2026
ToobLac added 5 commits July 25, 2026 21:04
# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java
#	HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/ModrinthRemoteAddonRepository.java
# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java
@Glavo

Glavo commented Aug 1, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ede77690a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/util/StringUtils.java Outdated
@Glavo

Glavo commented Aug 12, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 6f32a6ce4d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ToobLac and others added 6 commits August 12, 2026 21:34
# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPageSkin.java
#	HMCL/src/main/java/org/jackhuang/hmcl/util/i18n/I18n.java
#	HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/ModLoaderType.java
#	HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/CurseForgeRemoteAddonRepository.java
@Glavo

Glavo commented Sep 8, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T13:53:11.148058Z fdb8b24 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fdb8b24c36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/AddonLoader.java Outdated
@Glavo
Glavo merged commit 7331f61 into HMCL-dev:main Sep 8, 2026
3 checks passed
@ToobLac
ToobLac deleted the fix-6280 branch September 8, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 模组下载列表不显示 Bukkit/Velocity/BungeeCoed标签

3 participants