Skip to content

enhance(macos): 日志、游戏崩溃、HMCL崩溃窗口按下 CMD+W 时退出 - #6813

Merged
Glavo merged 2 commits into
HMCL-dev:mainfrom
ToobLac:log-cmd-w
Sep 11, 2026
Merged

Glavo merged 2 commits into
HMCL-dev:mainfrom
ToobLac:log-cmd-w

Conversation

@ToobLac

@ToobLac ToobLac commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

其中日志窗口只有在游戏进程退出后才会允许快捷键关闭,防止误触

@github-actions github-actions Bot added the 10+ label Sep 5, 2026
@Glavo

Glavo commented Sep 10, 2026

Copy link
Copy Markdown
Member

这个功能意义大吗?macOS 上其他软件都是这种行为?

@ToobLac

ToobLac commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

这个功能意义大吗?macOS 上其他软件都是这种行为?

我的理解是用 native 标题栏且不算特别重要的窗口都应该遵循这个行为。macOS 的一大特色就是强大的快捷键,相当一部分用户已经养成了 CMD+W 关闭窗口和 CMD+Q 退出程序的习惯。

*特别重要 指启动器主窗口、游戏窗口等承载重要功能且难以重新打开的窗口

@Glavo

Glavo commented Sep 11, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-11T02:17:58.178755Z 7393f65 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7393f65585

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/FXUtils.java Outdated
@Glavo
Glavo merged commit 5b26b8f into HMCL-dev:main Sep 11, 2026
3 checks passed
@ToobLac
ToobLac deleted the log-cmd-w branch September 11, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants