feat(worklist): render DeepRV results - #446
Merged
Merged
Conversation
There was a problem hiding this comment.
Sorry @JacquesDelfrate, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 5 days by commenting @sourcery-ai review. Upgrade to get a review now.
Reviewer's GuideIntroduces a contract-gated DeepRV@1.0.0 Worklist renderer that displays localized, accessible RV function status and probability while preserving generic fallback behavior and preventing model-authored HTML from being rendered. Sequence diagram for DeepRV Worklist result displaysequenceDiagram
participant Drawer as WorklistDrawer
participant Renderer as ModelResultRenderer
participant Registry as RendererRegistry
participant Contract as DeepRVContract
participant View as DeepRVResult
Drawer->>Renderer: render ModelExecutionResult
Renderer->>Registry: resolveModelResultRenderer(result)
Registry->>Contract: parseDeepRVResultPayload(result.result)
Contract-->>Registry: validated DeepRVResultPayload
Registry-->>Renderer: kind deeprv and payload
Renderer->>View: render payload
View-->>Drawer: localized RV status and probability
Flow diagram for contract-gated DeepRV result renderingflowchart TD
A["Completed study-service result"] --> B{"Model is DeepRV@1.0.0?"}
B -- No --> G["Generic result renderer"]
B -- Yes --> C["parseDeepRVResultPayload"]
C --> D{"Payload valid?"}
D -- No --> G
D -- Yes --> E["DeepRVResult"]
E --> F["Localized accessible status and probability"]
E --> H["Ignore model-authored diagnosis and recommendation HTML"]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
…-renderer # Conflicts: # platform/app/src/components/inference/studyProcessing/ModelExecutionResultDrawer.test.tsx # platform/app/src/components/inference/studyProcessing/index.ts # platform/app/src/components/inference/studyProcessing/modelResults/ModelResultRenderer.test.tsx # platform/app/src/components/inference/studyProcessing/modelResults/ModelResultRenderer.tsx # platform/app/src/components/inference/studyProcessing/modelResults/modelResultRendererRegistry.test.ts # platform/app/src/components/inference/studyProcessing/modelResults/modelResultRendererRegistry.ts # platform/i18n/src/locales/en-US/StudyList.json # platform/i18n/src/locales/fr/StudyList.json # platform/i18n/src/locales/test-LNG/StudyList.json
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeepRV@1.0.0result contract for the deployed numeric class payloadValidation
default-casewarning remains inModelResultRenderer.tsxgit diff --check: passedCloses #445
Summary by Sourcery
Add supported DeepRV 1.0.0 result rendering to the Worklist while preserving safe generic fallbacks for invalid or unsupported results.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: