fix(riscv): support RV32 amocas.d register pairs - #332
Open
carlosqwqqwq wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
I rechecked the remaining red Microkernel check against the exact base and the PR file scope.
Based on this comparison, the remaining failure is caused by the shared workflow's moving |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(riscv): support RV32 amocas.d register pairs
Summary
Accept RV32
AMOCAS.Dwith evenrd/rs2pairs and implement the 64-bitcompare, swap, and old-value writeback across the pair. RV64 behavior is
unchanged.
Validation
7f162b19aeaa47825c82fb1c77ca042f535124e3.git apply --check --whitespace=erroron the exact isolated base: passed.git diff --check: passed.cargo test --lib -- --nocapture— 181 passed,including
rv32_amocas_d_decodes_and_uses_register_pairs..DAMO encodings remainillegal; only Zacas
AMOCAS.Duses the RV32 register-pair form.the three failures are existing vector tests and reproduce on the same
unpatched baseline, so none is introduced by this V-074 diff.
on head
e1a8f7ff034c11cc01f0a4aa7bd7662b188d52cf. The sharedbuild + bootjob currently fails before reaching RAX code inmicrokernel/src/arch.rsbecause this runner's Rust/LLVM rejects existingsse/avx/avx2/avx512ftarget features; the exact-base Microkernel run passed.The RV32 oracle boundary remains documented in the Issue.
Closes #329