fix(riscv): keep directed FP rounding residuals exact - #333
Open
carlosqwqqwq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(riscv): keep directed FP rounding residuals exact
Summary
Order the operands by magnitude before the Fast2Sum residual calculation so
the correction remains finite at max-finite top-binade midpoints. Add f32 and
f64 regression coverage for the directed and nearest rounding results.
Validation
7f162b19aeaa47825c82fb1c77ca042f535124e3.git apply --checkon the exact isolated base: passed.git diff --check: passed.cargo test --lib -- --nocapture— 181 passed,including both midpoint rounding tests.
cargo test --lib—8601 passed, 0 failed, 2 ignored.
build + bootjob currently fails before reaching RAX code inmicrokernel/src/arch.rsbecause this runner's Rust/LLVM rejects existingsse/avx/avx2/avx512ftarget features; the exact-base Microkernel run passed.Closes #330