Repository navigation
Conversation
What: removes the restriction that only the `master` branch and branches starting with `hotfix/` will trigger the ret-turkey workflow. Why: the build job in turkeyGitops that ret-turkey calls is useful for all branches (it tests whether the code builds, but doesn't try to push anything) and the tag jobs that push Docker images are restricted to the correct branches in turkeyGitops, so restricting the branches here in the calling workflow is no longer needed/helpful. Note: the branch restrictions were originally put in place in Hubs-Foundation#731 before turkeyGitops had been updated to have the restrictions itself in Hubs-Foundation/hubs-ops#210.
|
Thank you for the pull request. ROADMAP STATUS: This pull request isn't currently on any roadmap. Updates will be conveyed here as its place on/off a roadmap changes. You can view the roadmaps here: Roadmaps Google Drive folder. For more information on how the roadmaps work, see our roadmaps policy on GitHub. |
Member
Author
|
@DougReeder This PR didn't need rebasing and has already been approved, so I'm merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the restriction that only the
masterbranch and branches starting withhotfix/will trigger the ret-turkey workflow.Why?
The build job in turkeyGitops that ret-turkey calls is useful for all branches (it tests whether the code builds, but doesn't try to push anything) and the tag jobs that push Docker images are restricted to the correct branches in turkeyGitops, so restricting the branches here in the calling workflow is no longer needed/helpful.
Examples
N/A
How to test
Documentation of functionality
This workflow isn't currently documented, so there isn't any documentation to update, plus this change makes it consistent with all the other workflows that call turkeyGitops.
Known limitations
This PR doesn't change any of the ignored paths. The ignored paths aren't entirely consistent across the calling workflows for turkeyGitops and changing them wasn't discussed, so they are deemed out of scope for this PR.
Alternative implementations considered
None.
Open questions
None.
Additional details or related context
The branch restrictions were originally put in place in #731 before turkeyGitops had been updated to have the restrictions itself in Hubs-Foundation/hubs-ops#210.
This change was discussed at the 2026-07-07 Hubs Dev Meetup.